Repository navigation
fix(cloudflare): Capture NonRetryableError before the final workflow step attempt - #26161
Merged
Merged
Conversation
…rkflow step attempt Step errors were only captured once retries were exhausted, but a NonRetryableError ends the instance on an earlier attempt, so it was never reported. Also capture errors the Workflows engine treats as non-retryable (name or message prefix). Fixes #26091 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Member
Author
|
bugbot run |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 39f0684. Configure here.
Contributor
size-limit report 📦Compared: f325269 (PR test merge using develop at 4c9a4eb) Against: 4c9a4eb (develop) · base run #65205 ✅ Baseline matches: this diff contains only this PR's changes.
|
Contributor
Optional E2E testsSome optional checks were not successful. They do not block the merge. 3 not successful, 25 successful. See the run.
Successful checks
|
chargome
marked this pull request as ready for review
November 6, 2026 10:41
chargome
requested review from
JPeer264,
andreiborza,
isaacs,
mydea and
nicohrubec
and removed request for
a team and
mydea
November 6, 2026 10:41
andreiborza
approved these changes
Nov 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since #21025,
instrumentWorkflowWithSentryonly captures a step error once retries are exhausted. ANonRetryableErrorends the instance on an earlier attempt, so it was never reported. We now also capture errors the Workflows engine treats as non-retryable, using the engine's own rule (name === 'NonRetryableError'or a message starting withNonRetryableError) so we don't importcloudflare:workflowsat runtime.Closes #26091